Fix MySQL visibility select query #3909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
reviewed
Feb 7, 2023
| @@ -223,7 +223,7 @@ func (c *mysqlQueryConverter) buildSelectStmt( | |||
| return fmt.Sprintf( | |||
| `SELECT %s | |||
| FROM executions_visibility ev | |||
| INNER JOIN custom_search_attributes | |||
| LEFT JOIN custom_search_attributes | |||
There was a problem hiding this comment.
What's about other 2 (PostgreSQL and SQLite)?
alexshtin
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
MySQL select query for visibility change to do
LEFT JOINinstead ofINNER JOIN.Why?
For backward compatibility, old workflows won't have a corresponding row in
custom_search_attributestable, but they are valid workflows. Doing a left join makes sure that all executions are listed correctly.How did you test it?
Started Server using standard visibility, created workflows, upgraded DB schema to support advanced visibility, and restarted Server. Open UI to list all workflows, and now it's listing everything.
Potential risks
None.
Is hotfix candidate?
No.