Messages protocol implementation #3843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
commented
Jan 25, 2023
Comment on lines
+545
to
+550
| newWorkflowTaskType := enumsspb.WORKFLOW_TASK_TYPE_UNSPECIFIED | ||
| if ms.IsWorkflowExecutionRunning() && (hasBufferedEvents || request.GetForceCreateNewWorkflowTask() || activityNotStartedCancelled) { | ||
| newWorkflowTaskType = enumsspb.WORKFLOW_TASK_TYPE_NORMAL | ||
| } | ||
| createNewWorkflowTask := newWorkflowTaskType != enumsspb.WORKFLOW_TASK_TYPE_UNSPECIFIED | ||
|
|
There was a problem hiding this comment.
This block looks little weird but there are more cases to come in #3822.
alexshtin
commented
Jan 25, 2023
Comment on lines
+907
to
+908
|
|
||
| return nil |
There was a problem hiding this comment.
This will have real code in #3822.
alexshtin
commented
Jan 25, 2023
Comment on lines
+264
to
+265
|
|
||
| return nil |
There was a problem hiding this comment.
This will have real code in #3822.
1011173 to
bc4ec00
Compare
mmcshane
approved these changes
Jan 25, 2023
yycptt
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Messages protocol implementation.
Corresponding API changes: temporalio/api#253.
Why?
The protocol is used by upcoming synchronous workflow update feature: #3822.
How did you test it?
Integration tests in #3822.
Potential risks
No risks.
Is hotfix candidate?
No.