Skip to content

Add dynamic config for sdk worker options #3806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jan 25, 2023
Merged

Add dynamic config for sdk worker options #3806

merged 14 commits into from
Jan 25, 2023

Conversation

dnr
Copy link
Contributor

@dnr dnr commented Jan 12, 2023

What changed?

  • Add process-level dynamic config for sdk worker sticky cache size.
  • Remove direct calls to worker.New and use factory.
  • Collapse sdk client and worker factories to one, since they're always used together.
  • Add dynamic config for per-namespace workers.

Use like:

worker.perNamespaceWorkerOptions:
- value:
    MaxConcurrentWorkflowTaskPollers: 10
    WorkerLocalActivitiesPerSecond: 100

Why?
Allows more sdk worker tuning.

How did you test it?
not yet

Potential risks

Is hotfix candidate?

@dnr dnr requested a review from a team as a code owner January 12, 2023 23:13
@dnr dnr requested a review from Quinn-With-Two-Ns January 12, 2023 23:13
Quinn-With-Two-Ns
Quinn-With-Two-Ns reviewed Jan 13, 2023
View reviewed changes
Quinn-With-Two-Ns
Quinn-With-Two-Ns reviewed Jan 13, 2023
View reviewed changes
alexshtin
alexshtin reviewed Jan 20, 2023
View reviewed changes
@dnr dnr merged commit 278f545 into temporalio:master Jan 25, 2023
@dnr dnr deleted the sched37 branch January 25, 2023 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quinn-With-Two-Ns Quinn-With-Two-Ns Quinn-With-Two-Ns approved these changes

+1 more reviewer

@alexshtin alexshtin alexshtin approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dnr @alexshtin @Quinn-With-Two-Ns