Skip to content

Document that errors in goro.Group.Go functions are ignored #3734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 20, 2022
Merged

Document that errors in goro.Group.Go functions are ignored #3734

merged 2 commits into from
Dec 20, 2022

Conversation

MichaelSnowden
Copy link
Contributor

What changed?
We now explicitly ignore errors in the Go method of this package, and we document that errors from provided functions are ignored.

Why?
Part of the error-checking initiative

How did you test it?
By rerunning errcheck

Potential risks
None

Is hotfix candidate?
No

@MichaelSnowden MichaelSnowden requested a review from a team as a code owner December 20, 2022 01:57
@MichaelSnowden MichaelSnowden merged commit 12e4162 into master Dec 20, 2022
@MichaelSnowden MichaelSnowden deleted the errcheck/internal/goro branch December 20, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yycptt yycptt yycptt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelSnowden @yycptt