Filter replication task on source cluster #3641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
reviewed
Nov 22, 2022
7089d94 to
dffd2aa
Compare
yux0
approved these changes
Dec 2, 2022
yiminc
approved these changes
Dec 4, 2022
|
|
||
| ns, err := p.namespaceRegistry.GetNamespaceByID(namespace.ID(task.GetNamespaceID())) | ||
| if err != nil { | ||
| if _, isNotFound := err.(*serviceerror.NamespaceNotFound); !isNotFound { |
There was a problem hiding this comment.
Is it possible that this could happen after host restart and before ns refresh fetched the namespace info?
There was a problem hiding this comment.
First call to load namespaces is from registry.Start method, which is blocking and called by fx during container is getting built.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Filter replication tasks on source cluster.
Why?
The source cluster should skip replication tasks, if the destination (calling) cluster is not in the cluster list for the task namespace.
How did you test it?
Added new unit tests and validated locally with 3 clusters setup.
Potential risks
No risks.
Is hotfix candidate?
No.