Turns on the history scavenger for SQL backends #3452
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e1a04d7 to
2f41fdc
Compare
2f41fdc to
6fbe551
Compare
yycptt
reviewed
Oct 6, 2022
| go s.startWorkflowWithRetry(tlScannerWFStartOptions, tqScannerWFTypeName) | ||
| workerTaskQueueNames = append(workerTaskQueueNames, tqScannerTaskQueueName) | ||
| } else if s.context.cfg.Persistence.DefaultStoreType() == config.StoreTypeNoSQL && s.context.cfg.HistoryScannerEnabled() { | ||
| } else if s.context.cfg.HistoryScannerEnabled() { |
There was a problem hiding this comment.
else is not needed here? History scanner should be run if enabled regardless if task queue scanner is running or not I think.
There was a problem hiding this comment.
I'm not sure--that was the existing behavior
There was a problem hiding this comment.
I'll update it though because that makes sense to me
| DefaultStore: config.StoreTypeSQL, | ||
| ExpectedScanners: []expectedScanner{executionScanner}, | ||
| }, | ||
| } { |
There was a problem hiding this comment.
Plz add a test case where store type is SQL and all three scanners are enabled.
|
Is it to enable for SQL or NoSQL? |
SQL--changed the PR comment |
|
I accidentally closed this PR and deleted the old branch while trying to rename the branch. The new PR is here: #3462 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
In this PR, I enabled the history scanner to delete unused history tree branches.
Why?
I made these changes for #3419 in order to rule this out as an option for why disk usage is increasing so much over time for NoSQL backends.
How did you test it?
I added a new test to the Scanner which verifies that we actually start the scavenger now regardless of the storage backend we're using.
Potential risks
The biggest risk I can think of is that this change could turn on the scavenger for NoSQL backends, and it could have a bug which causes it to remove branches which it shouldn't, which could interfere with workflow progress and lead to data loss.
Is hotfix candidate?
This PR is not a hot fix candidate which requires a notification to the broader community. However, we should tell the people on the original PR that this fix is in, so that they can patch it and see if it fixes their issue.