Retry attempts to delete open workflow executions #3411
Merged
+211
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deab139 to
35fb1ce
Compare
alexshtin
reviewed
Sep 20, 2022
alexshtin
reviewed
Sep 20, 2022
a37cdc0 to
636101b
Compare
yycptt
reviewed
Sep 21, 2022
yux0
reviewed
Sep 21, 2022
dcc261f to
9753ac0
Compare
yux0
reviewed
Sep 22, 2022
| @@ -273,6 +280,12 @@ func (t *transferQueueTaskExecutorBase) deleteExecution( | |||
| } | |||
| } | |||
|
|
|||
| if checkForPendingCloseExecutionTask { | |||
There was a problem hiding this comment.
IMO, it is cleaner to move this logic into processDeleteExecutionTask and keep deleteExecution() as it is.
There was a problem hiding this comment.
Definitely, but I wanted it to be there so that I don't have to load mutable state twice.
9753ac0 to
3a33c90
Compare
…ask before deleting an execution
3a33c90 to
aa528dc
Compare
alexshtin
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #3368. It adds a check to our transfer task processor which ensures that tasks are closed before deleting them.