Add test for proxy to make sure all payloads are visited #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ested individually and then clean up code
# Conflicts: # proxy/interceptor_test.go
cretz
approved these changes
Mar 17, 2025
Comment on lines
+808
to
+810
| // TODO: https://github.com/temporalio/sdk-go/issues/1865 | ||
| "temporal.api.workflowservice.v1.CountWorkflowExecutionsResponse", | ||
| "temporal.api.workflowservice.v1.CountWorkflowExecutionsResponse.AggregationGroup", |
Sushisource
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add test for proxy to make sure all payloads are visited even if it's not reachable.
Why?
This uses a different approach than how our proxy codegen discovers things #210
How did you test it?
Added new tests
Discovered a few gaps while writing this new test
#1862
#1864
#1865
Potential risks
None, this is test-only changes