Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: temporalio/api-go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.50.0
Choose a base ref
...
head repository: temporalio/api-go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.50.1
Choose a head ref
  • 2 commits
  • 9 files changed
  • 2 contributors

Commits on Aug 4, 2025

  1. Add "Aborted" servicerror (#223)

    @stephanos @yycptt
    stephanos authored and yycptt committed Aug 4, 2025
    Configuration menu
    Copy the full SHA
    67eaf88 View commit details
    Browse the repository at this point in the history

  2. bug: add timestamp to TriggerImmediatelyRequest (#606) 

    _**READ BEFORE MERGING:** All PRs require approval by both Server AND
SDK teams before merging! This is why the number of required approvals
is "2" and not "1"--two reviewers from the same team is NOT sufficient.
If your PR is not approved by someone in BOTH teams, it may be summarily
reverted._

<!-- Describe what has changed in this PR -->
**What changed?**
adding a timestamp to `TriggerImmediatelyRequest` message

<!-- Tell your future self why have you made these changes -->
We can make the wft “more idempotent”: put the desired trigger time in
the trigger immediately request itself, so it goes in the signal
payload, so all wfts attempt to start the target with the same id.

<!-- Are there any breaking changes on binary or code level? -->
**Breaking changes**

<!-- If this breaks the Server, please provide the Server PR to merge
right after this PR was merged. -->
[**Server PR**](temporalio/temporal#7968)
    @spkane31 @yycptt
    spkane31 authored and yycptt committed Aug 4, 2025
    Configuration menu
    Copy the full SHA
    218ccbf View commit details
    Browse the repository at this point in the history
Loading