Fairness #617
Merged
Fairness #617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
reviewed
Jul 21, 2025
temporal/api/common/v1/message.proto
Outdated
| // amount of time (minutes). It may change, but it may take some time for | ||
| // the change to be reflected. | ||
| // | ||
| // The recommended range of usable weights is [0.001, 1000]. |
There was a problem hiding this comment.
Why this recommendation? Might be good to elaborate.
There was a problem hiding this comment.
Let me see ... so the code won't allow anything smaller than 0.001 or larger than 1000.
So they are allowed to pass in something smaller or larger; it just won't have an effect. I don't know if we have plans to change that range in the future and don't want to hard-code that as a hard-requirement.
There was a problem hiding this comment.
I'd be fine with saying values are currently clamped to that range (more than fine - it seems key that that will happen vs. just "recommended")
dnr
approved these changes
Jul 21, 2025
Co-authored-by: David Reiss <david@temporal.io>
Co-authored-by: David Reiss <david@temporal.io>
Sushisource
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READ BEFORE MERGING: All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted.
What changed?
Already discussed and approved previously here.
Breaking changes
N/A
Server PR
https://github.com/temporalio/temporal/tree/feature/fairness