Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First step in fixing #914. cc @KnorpelSenf
Currently
session
has 2 "failure modes":getSessionKey(ctx)
returnsnull
,session
remains unsetSessionData
instore
or it's expired,session
is set to{}
.I believe changing the latter to also not set
session
would simplify things. The former behavior can be achieved withctx.session ??= {}
if desired.I don't care about getting this merged; the typed way to attach (optional) data to
ctx
isWeakMap
/ https://yarnpkg.com/package/@emotion/weak-memoize.How has this been tested?
This code continues passing typecheck:
session.ts
itself has one type error that I cannot solve, hence draft.Checklist: