Skip to content

Add TBA 8.0 support #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jun 19, 2025
Merged

Add TBA 8.0 support #1369

merged 14 commits into from
Jun 19, 2025

Conversation

shdwchn10
Copy link
Member

Closes #1275

r? @LasterAlex

@shdwchn10 shdwchn10 requested a review from LasterAlex June 17, 2025 23:32
@teloxidebot teloxidebot added A-requester Area: requester trait, bot adaptors A-requests Area: representation of telegram bot API requests/methods A-tba-types Area: representation of telegram bot API types C-core crate: teloxide-core C-main crate: teloxide S-waiting-on-review Status: Awaiting review from the assignee labels Jun 17, 2025
@shdwchn10 shdwchn10 mentioned this pull request Jun 17, 2025
Closed
15 tasks
@shdwchn10
Copy link
Member Author

shdwchn10 commented Jun 18, 2025 •
edited
Loading

@LasterAlex btw, I'm starting to think that I could make custom impls of Eq and Hash on Gift struct ignoring the sticker field, because it seems irrelevant. Anyway Gift::id is unique according to the TBA docs. This would make breaking change unnecessary. What do you think?

UPD: We decided to go with these impls on MaskPosition instead

LasterAlex
LasterAlex requested changes Jun 18, 2025
View reviewed changes
Copy link
Collaborator

@LasterAlex LasterAlex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few corrections and questions, other than that everything looks good!

@teloxidebot teloxidebot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author and removed S-waiting-on-review Status: Awaiting review from the assignee labels Jun 18, 2025
@shdwchn10 shdwchn10 force-pushed the feature/tba-support/8.0 branch from f395912 to fa87dcf Compare June 19, 2025 10:49
@shdwchn10 shdwchn10 requested a review from LasterAlex June 19, 2025 10:50
@teloxidebot teloxidebot added S-waiting-on-review Status: Awaiting review from the assignee and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author labels Jun 19, 2025
LasterAlex
LasterAlex approved these changes Jun 19, 2025
View reviewed changes
Copy link
Collaborator

@LasterAlex LasterAlex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shdwchn10 shdwchn10 added this pull request to the merge queue Jun 19, 2025
Merged via the queue into master with commit d0a0f6c Jun 19, 2025
9 checks passed
@shdwchn10 shdwchn10 deleted the feature/tba-support/8.0 branch June 19, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LasterAlex LasterAlex LasterAlex approved these changes

Assignees

@LasterAlex LasterAlex

Labels
A-requester Area: requester trait, bot adaptors A-requests Area: representation of telegram bot API requests/methods A-tba-types Area: representation of telegram bot API types C-core crate: teloxide-core C-main crate: teloxide S-waiting-on-review Status: Awaiting review from the assignee
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for TBA 8.0
3 participants
@shdwchn10 @LasterAlex @teloxidebot