Skip to content

Conversation

LasterAlex
Copy link
Collaborator

@teloxidebot teloxidebot added A-requester Area: requester trait, bot adaptors A-requests Area: representation of telegram bot API requests/methods A-tba-types Area: representation of telegram bot API types C-core crate: teloxide-core C-main crate: teloxide S-waiting-on-review Status: Awaiting review from the assignee labels Jun 15, 2025
Copy link
Member

@shdwchn10 shdwchn10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave some suggestions. Also this PR is missing new ReactionTypePaid (last line in the official changelog)

@teloxidebot teloxidebot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author and removed S-waiting-on-review Status: Awaiting review from the assignee labels Jun 15, 2025
@LasterAlex
Copy link
Collaborator Author

ReactionTypePaid already exists (look at types/reaction_type.rs

@LasterAlex LasterAlex requested a review from shdwchn10 June 15, 2025 19:57
@teloxidebot teloxidebot added S-waiting-on-review Status: Awaiting review from the assignee and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author labels Jun 15, 2025
Copy link
Member

@shdwchn10 shdwchn10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@shdwchn10 shdwchn10 added this pull request to the merge queue Jun 15, 2025
Merged via the queue into master with commit c1e9e85 Jun 15, 2025
9 checks passed
@shdwchn10 shdwchn10 deleted the add-7.9 branch June 15, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-requester Area: requester trait, bot adaptors A-requests Area: representation of telegram bot API requests/methods A-tba-types Area: representation of telegram bot API types C-core crate: teloxide-core C-main crate: teloxide S-waiting-on-review Status: Awaiting review from the assignee
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants