PHP8 errors and several other fixes #265

brainfoolong · 2020-08-19T14:18:50Z

Resent to main branch as noted here #244 (comment)

…r *"

…ion errors

…h would've resulted in errors

Co-authored-by: William Desportes <williamdes@wdes.fr>

williamdes · 2020-10-22T13:39:48Z

Fixes: #222

@nicolaasuni could you please have a look ?

fezfez · 2020-11-27T19:00:57Z

any news ?

vladislavtkachenko · 2020-12-07T17:55:43Z

someone alive?)

brainfoolong · 2020-12-07T18:35:47Z

I can't give any information, it's now maintainers turn.

CLAassistant · 2020-12-09T07:02:23Z

All committers have signed the CLA.

nicolaasuni · 2020-12-09T07:04:25Z

include/tcpdf_static.php

@@ -1136,7 +1136,7 @@ public static function extractCSSproperties($cssdata) {
 	 * @see setHtmlVSpace()
 	 * @public static
 	 */
-	public static function fixHTMLCode($html, $default_css='', $tagvs='', $tidy_options='', &$tagvspaces) {
+	public static function fixHTMLCode($html, $default_css, $tagvs, $tidy_options, &$tagvspaces) {


This seems a braking change

Hi, its not. The last Parameter was never optional, so all user code must have defined those parameters. So all code use this function have already those params.

nicolaasuni · 2020-12-09T07:06:03Z

include/barcodes/datamatrix.php

@@ -470,7 +470,7 @@ protected function get255StateCodeword($cwpad, $cwpos) {
 	 * Returns true if the char belongs to the selected mode
 	 * @param $chr (int) Character (byte) to check.
 	 * @param $mode (int) Current encoding mode.
-	 * @return boolean true if the char is of the selected mode.
+	 * @return bool true if the char is of the selected mode.


Instead of fixing these barcode functions it would probably be easier to just import the new tc-lib-barcode library that is ready.

Would that be a breaking change?

nicolaasuni · 2020-12-09T07:06:57Z

include/tcpdf_static.php

@@ -1136,7 +1136,7 @@ public static function extractCSSproperties($cssdata) {
 	 * @see setHtmlVSpace()
 	 * @public static
 	 */
-	public static function fixHTMLCode($html, $default_css='', $tagvs='', $tidy_options='', &$tagvspaces) {
+	public static function fixHTMLCode($html, $default_css, $tagvs, $tidy_options, &$tagvspaces) {


Is this a breaking change?

Hi, its not. The last Parameter was never optional, so all user code must have defined those parameters. So all code use this function have already those params.

nicolaasuni · 2020-12-09T07:08:08Z

tcpdf.php

-					$w = $w;
 					break;
 				}
 				case 'L': {
-					if ($this->rtl) {
-						$w = $w;
-					} else {
+					if (!$this->rtl) {
 						$w = $l;
 					}
 					break;
 				}
 				case 'R': {
 					if ($this->rtl) {
 						$w = $l;
-					} else {
-						$w = $w;


This seems another breaking change?

nicolaasuni · 2020-12-09T07:08:28Z

tcpdf.php

@@ -7779,16 +7777,16 @@ public function _destroy($destroyall=false, $preserve_objcopy=false) {
 			// remove all temporary files
 			if ($handle = @opendir(K_PATH_CACHE)) {
 				while ( false !== ( $file_name = readdir( $handle ) ) ) {
-					if (strpos($file_name, '__tcpdf_'.$this->file_id.'_') === 0) {
+					if (strpos($file_name, '__tcpdf_'.$this->file_id.'_') === 0 && file_exists(K_PATH_CACHE.$file_name)) {


file_exists is a security issue.

Could you explain why, it would be interesting :)

williamdes · 2020-12-09T07:19:33Z

include/tcpdf_static.php

@@ -1136,7 +1136,7 @@ public static function extractCSSproperties($cssdata) {
 	 * @see setHtmlVSpace()
 	 * @public static
 	 */
-	public static function fixHTMLCode($html, $default_css='', $tagvs='', $tidy_options='', &$tagvspaces) {
+	public static function fixHTMLCode($html, $default_css, $tagvs, $tidy_options, &$tagvspaces) {


https://stackoverflow.com/a/16636807/5155484

Suggested change

public static function fixHTMLCode($html, $default_css, $tagvs, $tidy_options, &$tagvspaces) {

public static function fixHTMLCode($html, $default_css = '', $tags = '', $tidy_options = '', &$tagvspaces = null) {

williamdes · 2020-12-09T07:21:47Z

I think according to https://stackoverflow.com/a/16636807/5155484 it could be set to null the default parameters to not introduce bc breaks
But the default value should be checked that the code is ready for it

include/tcpdf_fonts.php

williamdes · 2020-12-09T08:03:38Z

#293 was merged and did out-date this pull-request

brainfoolong · 2020-12-09T08:08:07Z

Ok, i am out of this library. I did my best to help. Cya.

ricoBolo06 · 2021-01-04T22:34:47Z

I made the change that you propose, but I still get the error with export from phpMyAdmin ( from xampp distrib / windows).
error => Deprecation Notice in .\vendor\tecnickcom\tcpdf\include\tcpdf_static.php
As export is an important function in phpMyadmin, could you tell me how we can resolve this pb ? Where we can find source ? Thank for help

ricoBolo06 · 2021-01-04T22:51:57Z

I just reproduce the pb :

Deprecation Notice in .\vendor\twig\twig\src\Node\IncludeNode.php#25
 Required parameter $lineno follows optional parameter $only

Backtrace

.\vendor\composer\ClassLoader.php#444: include()
.\vendor\composer\ClassLoader.php#322: Composer\Autoload\includeFile(string 'D:\\7Prod\\wwwroot\\Admin\\phpMyAdmin\\vendor\\composer/../twig/twig/src/Node/IncludeNode.php')
.\vendor\twig\twig\src\TokenParser\IncludeTokenParser.php#33: Composer\Autoload\ClassLoader->loadClass(string 'Twig\\Node\\IncludeNode')
.\vendor\twig\twig\src\Parser.php#209: Twig\TokenParser\IncludeTokenParser->parse()
.\vendor\twig\twig\src\TokenParser\ForTokenParser.php#51: Twig\Parser->subparse(array)
.\vendor\twig\twig\src\Parser.php#209: Twig\TokenParser\ForTokenParser->parse()
.\vendor\twig\twig\src\Parser.php#122: Twig\Parser->subparse(
NULL,
boolean false,
)
.\vendor\twig\twig\src\Environment.php#735: Twig\Parser->parse()
.\vendor\twig\twig\src\Environment.php#793: Twig\Environment->parse()
.\vendor\twig\twig\src\Environment.php#482: Twig\Environment->compileSource()
.\vendor\twig\twig\src\Environment.php#445: Twig\Environment->loadClass(
string '__TwigTemplate_82a1bb593753cedc13c5589a395e58ea45db18d4fa2fc2fcfc27ad4d2166fb7f',
string 'database/structure/table_header.twig',
NULL,
)
.\vendor\twig\twig\src\Environment.php#423: Twig\Environment->loadTemplate(string 'database/structure/table_header.twig')
.\libraries\classes\Template.php#115: Twig\Environment->load(string 'database/structure/table_header.twig')
.\libraries\classes\Controllers\Database\DatabaseStructureController.php#727: PhpMyAdmin\Template->render(array)
.\libraries\classes\Controllers\Database\DatabaseStructureController.php#195: PhpMyAdmin\Controllers\Database\DatabaseStructureController->displayTableList()
.\db_structure.php#38: PhpMyAdmin\Controllers\Database\DatabaseStructureController->indexAction()

with phpMyAdmin Version : 4.9.7
Apache/2.4.46 (Win64) OpenSSL/1.1.1h PHP/8.0.0
Version du client de base de données : libmysql - mysqlnd 8.0.0
Extension PHP : mysqliDocumentation mbstringDocumentation
Version de PHP : 8.0.0

thank for any help,

brainfoolong and others added 15 commits June 30, 2020 09:32

added gitattributes to force LF line endings

e72ac6b

added php always use lf line endings

e5cad8c

fixes for php8 errors "Required parameter * follows optional paramete…

b879717

…r *"

fixed missing break in switch

dd11e45

fixed variable conflict

8ad06f8

fixed silly/useless assignments

2c02d66

fixed wrong float/int cast errors result in false positive concatenat…

f3fa222

…ion errors

removed unused function which also contained undefinded constant whic…

d6321f5

…h would've resulted in errors

dirty-fixed a undefined variables

64c7ef5

fixed visibility some doc annotations

ae96743

dirty-fixed a undefined variables

c968b11

fixed unlink file that don't exist result in error

227cb08

made each variable init in single lines

d4e1762

Co-authored-by: William Desportes <williamdes@wdes.fr>

reverted short array syntax for php compatibility

4f0cd0e

exported .github folder

587ef21

brainfoolong changed the title ~~Fixes~~ PHP8 errors and several other fixes Aug 19, 2020

brainfoolong mentioned this pull request Oct 22, 2020

Fix optionnal parameters declaration (PHP8) #293

Merged

Update .gitattributes

46a2adc

nicolaasuni requested changes Dec 9, 2020

View reviewed changes

williamdes reviewed Dec 9, 2020

View reviewed changes

include/tcpdf_fonts.php Show resolved Hide resolved

brainfoolong closed this Dec 9, 2020

brainfoolong deleted the fixes branch December 9, 2020 08:08

williamdes mentioned this pull request Dec 9, 2020

TCPDF Deprecation errors on PHP 8.0 phpmyadmin/phpmyadmin#16268

Closed

	public static function fixHTMLCode($html, $default_css, $tagvs, $tidy_options, &$tagvspaces) {
	public static function fixHTMLCode($html, $default_css = '', $tags = '', $tidy_options = '', &$tagvspaces = null) {

Uh oh!

PHP8 errors and several other fixes #265

PHP8 errors and several other fixes #265

Uh oh!

Conversation

brainfoolong commented Aug 19, 2020

Uh oh!

williamdes commented Oct 22, 2020

Uh oh!

fezfez commented Nov 27, 2020

Uh oh!

vladislavtkachenko commented Dec 7, 2020

Uh oh!

brainfoolong commented Dec 7, 2020

Uh oh!

CLAassistant commented Dec 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

williamdes commented Dec 9, 2020

Uh oh!

Uh oh!

williamdes commented Dec 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brainfoolong commented Dec 9, 2020

Uh oh!

ricoBolo06 commented Jan 4, 2021

Uh oh!

ricoBolo06 commented Jan 4, 2021

Uh oh!

Uh oh!

CLAassistant commented Dec 9, 2020 •

edited

Loading

williamdes commented Dec 9, 2020 •

edited

Loading