Develop #371
Merged
Develop #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [org.jacoco:jacoco-maven-plugin](https://github.com/jacoco/jacoco) from 0.8.12 to 0.8.13. - [Release notes](https://github.com/jacoco/jacoco/releases) - [Commits](jacoco/jacoco@v0.8.12...v0.8.13) --- updated-dependencies: - dependency-name: org.jacoco:jacoco-maven-plugin dependency-version: 0.8.13 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [org.springframework.boot:spring-boot-starter-parent](https://github.com/spring-projects/spring-boot) from 3.4.3 to 3.5.4. - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v3.4.3...v3.5.4) --- updated-dependencies: - dependency-name: org.springframework.boot:spring-boot-starter-parent dependency-version: 3.5.4 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [org.codehaus.mojo:flatten-maven-plugin](https://github.com/mojohaus/flatten-maven-plugin) from 1.6.0 to 1.7.2. - [Release notes](https://github.com/mojohaus/flatten-maven-plugin/releases) - [Commits](mojohaus/flatten-maven-plugin@1.6.0...1.7.2) --- updated-dependencies: - dependency-name: org.codehaus.mojo:flatten-maven-plugin dependency-version: 1.7.2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [org.apache.maven.plugins:maven-source-plugin](https://github.com/apache/maven-source-plugin) from 2.2.1 to 3.3.1. - [Release notes](https://github.com/apache/maven-source-plugin/releases) - [Commits](apache/maven-source-plugin@maven-source-plugin-2.2.1...maven-source-plugin-3.3.1) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-source-plugin dependency-version: 3.3.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [org.bouncycastle:bcprov-jdk18on](https://github.com/bcgit/bc-java) from 1.78 to 1.81. - [Changelog](https://github.com/bcgit/bc-java/blob/main/docs/releasenotes.html) - [Commits](https://github.com/bcgit/bc-java/commits) --- updated-dependencies: - dependency-name: org.bouncycastle:bcprov-jdk18on dependency-version: '1.81' dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps `spring-boot.version` from 3.4.3 to 3.5.4. Updates `org.springframework.boot:spring-boot-starter-websocket` from 3.4.3 to 3.5.4 - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v3.4.3...v3.5.4) Updates `org.springframework.boot:spring-boot-starter-test` from 3.4.3 to 3.5.4 - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v3.4.3...v3.5.4) Updates `org.springframework.boot:spring-boot-starter` from 3.4.3 to 3.5.4 - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v3.4.3...v3.5.4) --- updated-dependencies: - dependency-name: org.springframework.boot:spring-boot-starter-websocket dependency-version: 3.5.4 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.springframework.boot:spring-boot-starter-test dependency-version: 3.5.4 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.springframework.boot:spring-boot-starter dependency-version: 3.5.4 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [org.awaitility:awaitility](https://github.com/awaitility/awaitility) from 4.2.2 to 4.3.0. - [Changelog](https://github.com/awaitility/awaitility/blob/master/changelog.txt) - [Commits](awaitility/awaitility@awaitility-4.2.2...awaitility-4.3.0) --- updated-dependencies: - dependency-name: org.awaitility:awaitility dependency-version: 4.3.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [com.fasterxml.jackson.module:jackson-module-blackbird](https://github.com/FasterXML/jackson-modules-base) from 2.17.2 to 2.19.2. - [Commits](FasterXML/jackson-modules-base@jackson-modules-base-2.17.2...jackson-modules-base-2.19.2) --- updated-dependencies: - dependency-name: com.fasterxml.jackson.module:jackson-module-blackbird dependency-version: 2.19.2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [org.apache.maven.plugins:maven-surefire-plugin](https://github.com/apache/maven-surefire) from 3.3.0 to 3.5.3. - [Release notes](https://github.com/apache/maven-surefire/releases) - [Commits](apache/maven-surefire@surefire-3.3.0...surefire-3.5.3) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-surefire-plugin dependency-version: 3.5.3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [org.apache.maven.plugins:maven-failsafe-plugin](https://github.com/apache/maven-surefire) from 3.3.0 to 3.5.3. - [Release notes](https://github.com/apache/maven-surefire/releases) - [Commits](apache/maven-surefire@surefire-3.3.0...surefire-3.5.3) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-failsafe-plugin dependency-version: 3.5.3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…en.plugins-maven-failsafe-plugin-3.5.3 chore(deps): bump org.apache.maven.plugins:maven-failsafe-plugin from 3.3.0 to 3.5.3
…en.plugins-maven-surefire-plugin-3.5.3 chore(deps): bump org.apache.maven.plugins:maven-surefire-plugin from 3.3.0 to 3.5.3
…jackson.module-jackson-module-blackbird-2.19.2 chore(deps): bump com.fasterxml.jackson.module:jackson-module-blackbird from 2.17.2 to 2.19.2
…-awaitility-4.3.0 chore(deps): bump org.awaitility:awaitility from 4.2.2 to 4.3.0
…rsion-3.5.4 chore(deps): bump spring-boot.version from 3.4.3 to 3.5.4
…le-bcprov-jdk18on-1.81 chore(deps): bump org.bouncycastle:bcprov-jdk18on from 1.78 to 1.81
…-maven-source-plugin-3.3.1
…en.plugins-maven-source-plugin-3.3.1 chore(deps): bump org.apache.maven.plugins:maven-source-plugin from 2.2.1 to 3.3.1
…ojo-flatten-maven-plugin-1.7.2 chore(deps): bump org.codehaus.mojo:flatten-maven-plugin from 1.6.0 to 1.7.2
…ework.boot-spring-boot-starter-parent-3.5.4 chore(deps): bump org.springframework.boot:spring-boot-starter-parent from 3.4.3 to 3.5.4
…ns/checkout-5 chore(deps): bump actions/checkout from 4 to 5
…oco-maven-plugin-0.8.13 chore(deps): bump org.jacoco:jacoco-maven-plugin from 0.8.12 to 0.8.13
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project version from 0.8 to 0.2.2-SNAPSHOT and configures the build for development deployment. It replaces GitHub releases with a custom Maven repository deployment setup and updates various dependencies to newer versions.
- Version rollback from 0.8 to 0.2.2-SNAPSHOT for development builds
- Migration from GitHub release workflow to custom Maven repository (reposilite)
- Dependency updates including Spring Boot, Jackson, and Maven plugins
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Updates parent version, Spring Boot version, dependency versions, and adds distributionManagement configuration |
| nostr-java-*/pom.xml | Updates module versions and adds distributionManagement configuration to all child modules |
| .github/workflows/release.yml | Removes entire GitHub release workflow |
| .github/workflows/codeql-analysis.yml | Updates checkout action from v4 to v5 |
| .github/workflows/ci.yml | Updates checkout action from v4 to v5 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| @@ -3,13 +3,13 @@ | |||
|
|
|||
| <groupId>xyz.tcheeric</groupId> | |||
| <artifactId>nostr-java</artifactId> | |||
| <version>0.8</version> | |||
| <version>0.2.2-SNAPSHOT</version> | |||
There was a problem hiding this comment.
The version has been downgraded from 0.8 to 0.2.2-SNAPSHOT, which appears to be a backward version change. This could indicate a development branch divergence or potential confusion for users about version progression.
Suggested change
| <version>0.2.2-SNAPSHOT</version> | |
| <version>0.9.0-SNAPSHOT</version> |
Copilot uses AI. Check for mistakes.
| <maven.compiler.source>${java.version}</maven.compiler.source> | ||
| <maven.compiler.target>${java.version}</maven.compiler.target> | ||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
|
|
||
| <!-- Dependency Versions --> | ||
| <awaitility.version>4.2.2</awaitility.version> | ||
| <bcprov-jdk18on.version>1.81</bcprov-jdk18on.version> | ||
| <awaitility.version>4.3.0</awaitility.version> | ||
| <bcprov-jdk18on.version>1.78</bcprov-jdk18on.version> |
There was a problem hiding this comment.
There are now two bcprov-jdk18on.version properties defined (lines 86 and 88 with values 1.81 and 1.78 respectively). This duplicate property definition will cause the second value (1.78) to override the first one, making line 86 ineffective.
Suggested change
| <bcprov-jdk18on.version>1.78</bcprov-jdk18on.version> |
Copilot uses AI. Check for mistakes.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.