Split GitHub release workflow steps #364
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR splits the GitHub release workflow by separating the release creation and asset upload steps, removing redundant release creation logic and limiting the scope of GH_TOKEN usage to only the CLI steps that require it.
- Removes duplicate release creation code that was using GitHub CLI
- Streamlines the workflow by relying on the existing GitHub action for release creation
- Improves security by limiting
GH_TOKENscope to only necessary steps
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| @@ -59,14 +59,6 @@ jobs: | |||
| tag_name: ${{ github.ref }} | |||
| release_name: ${{ github.ref_name }} | |||
There was a problem hiding this comment.
The removed CLI command used --title "${{ github.ref }}" but the action uses release_name: ${{ github.ref_name }}. This creates an inconsistency where the release title will now be the tag name without the 'refs/tags/' prefix, potentially changing the expected release naming format.
| release_name: ${{ github.ref_name }} | |
| release_name: ${{ github.ref }} |
Copilot uses AI. Check for mistakes.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Summary
GH_TOKENusage to CLI stepsTesting
mvn -q verify(fails: Could not find a valid Docker environment)actionlint .github/workflows/release.ymlhttps://chatgpt.com/codex/tasks/task_b_689bb753a48c833190853d65ce90856e