-
Notifications
You must be signed in to change notification settings - Fork 24
Develop #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…sioning guideline
…ntExample.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…lass-and-methods feat: add NIP-40 expiration event example
…note-filters Add filter example
…tnoteevent Add TextNoteEvent example and update overview
…-publishing Add GitHub Packages publish workflow
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR appears to be preparing for a new development version by bumping the version from 0.7.3 to 0.8-SNAPSHOT across all Maven modules. The changes include adding comprehensive example code and documentation improvements.
- Version update from 0.7.3 to 0.8-SNAPSHOT across all Maven modules
- Addition of practical example classes demonstrating the Nostr Java API
- Documentation updates with expanded examples and GitHub Actions workflow for publishing
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 11 comments.
Show a summary per file
File | Description |
---|---|
pom.xml | Updates parent version and property to 0.8-SNAPSHOT |
Multiple module pom.xml files | Consistent version updates across all child modules |
Example Java classes | New comprehensive examples for text events, filters, and expiration events |
Documentation files | Enhanced README and codebase overview with practical examples |
GitHub Actions workflow | New workflow for automated publishing to GitHub Packages |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
@@ -3,7 +3,7 @@ | |||
|
|||
<groupId>xyz.tcheeric</groupId> | |||
<artifactId>nostr-java</artifactId> | |||
<version>0.7.3</version> | |||
<version>0.8-SNAPHOT</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version string contains a typo: 'SNAPHOT' should be 'SNAPSHOT'.
<version>0.8-SNAPHOT</version> | |
<version>0.8-SNAPSHOT</version> |
Copilot uses AI. Check for mistakes.
@@ -81,7 +81,7 @@ | |||
</modules> | |||
|
|||
<properties> | |||
<nostr-java.version>0.7.3</nostr-java.version> | |||
<nostr-java.version>0.8-SNAPHOT</nostr-java.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version property contains a typo: 'SNAPHOT' should be 'SNAPSHOT'.
<nostr-java.version>0.8-SNAPHOT</nostr-java.version> | |
<nostr-java.version>0.8-SNAPSHOT</nostr-java.version> |
Copilot uses AI. Check for mistakes.
@@ -4,7 +4,7 @@ | |||
<parent> | |||
<groupId>xyz.tcheeric</groupId> | |||
<artifactId>nostr-java</artifactId> | |||
<version>0.7.3</version> | |||
<version>0.8-SNAPHOT</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version string contains a typo: 'SNAPHOT' should be 'SNAPSHOT'.
<version>0.8-SNAPHOT</version> | |
<version>0.8-SNAPSHOT</version> |
Copilot uses AI. Check for mistakes.
@@ -4,7 +4,7 @@ | |||
<parent> | |||
<groupId>xyz.tcheeric</groupId> | |||
<artifactId>nostr-java</artifactId> | |||
<version>0.7.3</version> | |||
<version>0.8-SNAPHOT</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version string contains a typo: 'SNAPHOT' should be 'SNAPSHOT'.
<version>0.8-SNAPHOT</version> | |
<version>0.8-SNAPSHOT</version> |
Copilot uses AI. Check for mistakes.
@@ -4,7 +4,7 @@ | |||
<parent> | |||
<groupId>xyz.tcheeric</groupId> | |||
<artifactId>nostr-java</artifactId> | |||
<version>0.7.3</version> | |||
<version>0.8-SNAPHOT</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version string contains a typo: 'SNAPHOT' should be 'SNAPSHOT'.
<version>0.8-SNAPHOT</version> | |
<version>0.8-SNAPSHOT</version> |
Copilot uses AI. Check for mistakes.
@@ -4,7 +4,7 @@ | |||
<parent> | |||
<groupId>xyz.tcheeric</groupId> | |||
<artifactId>nostr-java</artifactId> | |||
<version>0.7.3</version> | |||
<version>0.8-SNAPHOT</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version string contains a typo: 'SNAPHOT' should be 'SNAPSHOT'.
<version>0.8-SNAPHOT</version> | |
<version>0.8-SNAPSHOT</version> |
Copilot uses AI. Check for mistakes.
@@ -4,7 +4,7 @@ | |||
<parent> | |||
<groupId>xyz.tcheeric</groupId> | |||
<artifactId>nostr-java</artifactId> | |||
<version>0.7.3</version> | |||
<version>0.8-SNAPHOT</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version string contains a typo: 'SNAPHOT' should be 'SNAPSHOT'.
<version>0.8-SNAPHOT</version> | |
<version>0.8-SNAPSHOT</version> |
Copilot uses AI. Check for mistakes.
@@ -4,7 +4,7 @@ | |||
<parent> | |||
<groupId>xyz.tcheeric</groupId> | |||
<artifactId>nostr-java</artifactId> | |||
<version>0.7.3</version> | |||
<version>0.8-SNAPHOT</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version string contains a typo: 'SNAPHOT' should be 'SNAPSHOT'.
<version>0.8-SNAPHOT</version> | |
<version>0.8-SNAPSHOT</version> |
Copilot uses AI. Check for mistakes.
@@ -4,7 +4,7 @@ | |||
<parent> | |||
<groupId>xyz.tcheeric</groupId> | |||
<artifactId>nostr-java</artifactId> | |||
<version>0.7.3</version> | |||
<version>0.8-SNAPHOT</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version string contains a typo: 'SNAPHOT' should be 'SNAPSHOT'.
<version>0.8-SNAPHOT</version> | |
<version>0.8-SNAPSHOT</version> |
Copilot uses AI. Check for mistakes.
@@ -4,7 +4,7 @@ | |||
<parent> | |||
<groupId>xyz.tcheeric</groupId> | |||
<artifactId>nostr-java</artifactId> | |||
<version>0.7.3</version> | |||
<version>0.8-SNAPHOT</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version string contains a typo: 'SNAPHOT' should be 'SNAPSHOT'.
<version>0.8-SNAPHOT</version> | |
<version>0.8-SNAPSHOT</version> |
Copilot uses AI. Check for mistakes.
No description provided.