Fix Spring Boot plugin declarations in Gradle modules #339
Conversation
There was a problem hiding this comment.
Pull Request Overview
The PR standardizes Spring Boot plugin declarations across Gradle modules by removing explicit version specifications and introduces a shared springBootVersion property to centralize version management.
- Removes explicit Spring Boot plugin versions from API and client module build.gradle files
- Introduces a new
springBootVersionproperty in gradle.properties for consistent version management - Updates dependency declarations to use the new shared property instead of hardcoded versions
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| nostr-java-client/build.gradle | Removes explicit Spring Boot plugin version and updates dependencies to use shared springBootVersion property |
| nostr-java-api/build.gradle | Removes explicit Spring Boot plugin version and updates dependencies to use shared springBootVersion property |
| gradle.properties | Adds new springBootVersion property while maintaining backward compatibility with existing nostr-java.springBootVersion |
| @@ -1,7 +1,6 @@ | |||
| plugins { | |||
| id 'java-library' | |||
| id 'org.springframework.boot' version "${rootProject.findProperty('nostr-java.springBootVersion')}" | |||
| id 'org.springframework.boot' version rootProject.findProperty('nostr-java.springBootVersion') | |||
| id 'org.springframework.boot' | |||
There was a problem hiding this comment.
The Spring Boot plugin declaration without a version will fail if no version is applied from a parent configuration. Since this appears to be a multi-module project, ensure the Spring Boot plugin version is applied at the root build.gradle or through a plugin management block.
| id 'org.springframework.boot' | |
| id 'org.springframework.boot' version "$springBootVersion" |
Copilot uses AI. Check for mistakes.
| @@ -1,7 +1,6 @@ | |||
| plugins { | |||
| id 'java-library' | |||
| id 'org.springframework.boot' version "${rootProject.findProperty('nostr-java.springBootVersion')}" | |||
| id 'org.springframework.boot' version rootProject.findProperty('nostr-java.springBootVersion') | |||
| id 'org.springframework.boot' | |||
There was a problem hiding this comment.
The Spring Boot plugin declaration without a version will fail if no version is applied from a parent configuration. Since this appears to be a multi-module project, ensure the Spring Boot plugin version is applied at the root build.gradle or through a plugin management block.
| id 'org.springframework.boot' | |
| id 'org.springframework.boot' version '3.2.6' |
Copilot uses AI. Check for mistakes.
Summary
springBootVersionproperty for dependency declarationsTesting
mvn -q verify(fails: Could not find a valid Docker environment)https://chatgpt.com/codex/tasks/task_b_689a4b7914808331a704c99a96463cae