Implement AutoCloseable for websocket clients #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…tandardWebSocketClient.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR implements the AutoCloseable interface for WebSocket clients to enable automatic resource management with try-with-resources blocks, improving resource cleanup and preventing potential memory leaks.
- Add AutoCloseable interface to WebSocketClientIF and provide a
close()method to replacecloseSocket() - Implement guarded session shutdown logic in StandardWebSocketClient to handle edge cases during close operations
- Update all usage sites and tests to use try-with-resources pattern for automatic cleanup
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| WebSocketClientIF.java | Extends AutoCloseable, adds close() method, deprecates closeSocket() |
| StandardWebSocketClient.java | Implements robust close() with null/state checks, deprecates closeSocket() |
| SpringWebSocketClient.java | Implements AutoCloseable, delegates to underlying client close() |
| WebSocketClientHandler.java | Updates to use new close() API instead of closeSocket() |
| Test files | Convert to try-with-resources pattern for automatic cleanup |
| @@ -111,7 +111,26 @@ public List<String> send(String json) throws IOException { | |||
| } | |||
|
|
|||
| @Override | |||
| public void close() throws IOException { | |||
| if (clientSession.isOpen()) { | |||
There was a problem hiding this comment.
This line appears to be unreachable code. Line 116 checks if clientSession is not null, but line 115 already calls isOpen() on clientSession without a null check, which would throw a NullPointerException if clientSession is null.
Suggested change
| if (clientSession.isOpen()) { |
Copilot uses AI. Check for mistakes.
nostr-java-client/src/main/java/nostr/client/springwebsocket/StandardWebSocketClient.java
Outdated
Show resolved
Hide resolved
…tandardWebSocketClient.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
WebSocketClientIFextendAutoCloseableand expose aclose()methodclose()implementations in Standard and Spring clientsclose()API and try-with-resourcesTesting
mvn -q verify(fails: Could not find a valid Docker environment)https://chatgpt.com/codex/tasks/task_b_689929b8f5048331bbde279ac9cf8e20