Add logging around WebSocket client operations #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request adds comprehensive debug logging to WebSocket client operations to improve observability and debugging capabilities. The changes focus on tracking message size, relay context, and client lifecycle events.
- Add debug logging for send operations with relay URL and message size tracking
- Enhance error logging in recovery methods with more detailed context
- Add logging around WebSocket client closure lifecycle
| @@ -70,12 +77,15 @@ public List<String> recover(IOException ex, String json) throws IOException { | |||
| */ | |||
| @Recover | |||
| public List<String> recover(IOException ex, BaseMessage eventMessage) throws IOException { | |||
| log.error("Failed to send message after retries: {}", eventMessage, ex); | |||
| String json = eventMessage.encode(); | |||
| log.error("Failed to send {} to relay {} after retries (size={} bytes)", eventMessage.getCommand(), relayUrl, json.length(), ex); | |||
| throw ex; | |||
| } | |||
There was a problem hiding this comment.
The eventMessage.encode() method is called again in the recovery method, which could be expensive if encoding is a heavy operation. Consider passing the already encoded JSON string to the recovery method instead of re-encoding.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
mvn -q verify(fails: Could not find a valid Docker environment)https://chatgpt.com/codex/tasks/task_b_689928cdf5e48331ae12c376f6b1a8bc