Handle Awaitility timeouts in StandardWebSocketClient #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves error handling in the StandardWebSocketClient by implementing proper timeout behavior. When Awaitility times out waiting for a relay response, the client now gracefully closes the WebSocket session and returns an empty list instead of potentially leaving resources hanging.
- Added timeout exception handling with session cleanup in StandardWebSocketClient
- Created comprehensive unit test to verify timeout behavior
- Updated documentation to clarify timeout handling expectations
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| StandardWebSocketClient.java | Added timeout exception handling, session cleanup, and package-private constructor for testing |
| StandardWebSocketClientTimeoutTest.java | New unit test covering timeout scenario with mocked WebSocket session |
| pom.xml | Added spring-boot-starter-test dependency for enhanced testing capabilities |
| CODEBASE_OVERVIEW.md | Documented timeout behavior and client response expectations |
nostr-java-client/src/main/java/nostr/client/springwebsocket/StandardWebSocketClient.java
Show resolved
Hide resolved
| @@ -1,7 +1,10 @@ | |||
| package nostr.client.springwebsocket; | |||
|
|
|||
| import lombok.NonNull; | |||
| import lombok.SneakyThrows; | |||
There was a problem hiding this comment.
The SneakyThrows import is added but not used in the code. This unused import should be removed to keep the codebase clean.
Suggested change
| import lombok.SneakyThrows; |
Copilot uses AI. Check for mistakes.
…tandardWebSocketClient.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
mvn -q verify(fails: Could not find a valid Docker environment for Testcontainers)https://chatgpt.com/codex/tasks/task_b_68991b88190083319adad62249be2947