Handle null consumer in Identity signing #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a potential NullPointerException in the Identity signing functionality by adding null safety checks for the signature consumer. The fix ensures that signing operations can safely handle ISignable objects that return null from their getSignatureConsumer() method.
- Added null check before calling accept() on the signature consumer
- Added test coverage for signing with a null signature consumer
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| nostr-java-id/src/main/java/nostr/id/Identity.java | Added null safety check for signature consumer before calling accept() |
| nostr-java-id/src/test/java/nostr/id/IdentityTest.java | Added test case to verify signing behavior with null signature consumer |
|
|
||
| @Override | ||
| public Supplier<ByteBuffer> getByteArraySupplier() { | ||
| return () -> ByteBuffer.wrap("payload".getBytes(StandardCharsets.UTF_8)); |
There was a problem hiding this comment.
Missing import for StandardCharsets. This will cause a compilation error.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
PATH=/bin:/usr/bin:$PATH ./mvnw -q verify(failed: Network is unreachable)https://chatgpt.com/codex/tasks/task_b_68991defe10c8331839b85e4e887c18d