Use Spring Boot BOM for client dependencies #288
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes explicit Spring Framework version management from the client module's POM file, allowing Spring Boot 3.4.3's BOM (Bill of Materials) to manage dependency versions automatically. This follows Spring Boot best practices for dependency management and ensures version consistency across Spring components.
- Removed explicit version declarations for Spring dependencies
- Deleted the
spring-websocket.versionproperty - Let Spring Boot BOM handle version resolution for spring-websocket, spring-retry, and spring-aspects
| @@ -58,12 +56,10 @@ | |||
| <dependency> | |||
| <groupId>org.springframework.retry</groupId> | |||
| <artifactId>spring-retry</artifactId> | |||
There was a problem hiding this comment.
The spring-retry dependency is missing its version declaration after removing the explicit version, but the ${spring-retry.version} property is still referenced in the diff context. This will cause a build failure if the property is not defined elsewhere or if Spring Boot BOM doesn't manage this dependency.
| <artifactId>spring-retry</artifactId> | |
| <artifactId>spring-retry</artifactId> | |
| <version>${spring-retry.version}</version> |
Copilot uses AI. Check for mistakes.
Summary
Testing
mvn -q verify(fails: Could not find a valid Docker environment. Please see logs and check configuration)Network Access
https://chatgpt.com/codex/tasks/task_b_68991ba5b3b083319b9741963e7dee02