Validate Filters map keys and limit #271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances validation and error handling in the Filters class by adding null checks for filter keys, positive limit validation, and constant error messages. The changes improve code robustness and maintainability.
- Replaced direct map access with
getOrDefaultfor cleaner filter lookup - Added validation for null filter keys and positive limit values
- Introduced constant error messages for consistent exception handling
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| nostr-java-event/src/main/java/nostr/event/filter/Filters.java | Enhanced validation logic with null checks, positive limit validation, and constant error messages |
| nostr-java-event/src/test/java/nostr/event/unit/FiltersTest.java | Added comprehensive unit tests covering new validation scenarios |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
getOrDefaultTesting
mvn -q verify(fails: Coverage checks have not been met for nostr-java-encryption)https://chatgpt.com/codex/tasks/task_b_6898e4fcce9c83318861268b88cb5a19