Protect event tags from external mutation #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR protects the GenericEvent class from external mutation by implementing defensive copying and immutable views of tag collections. The changes prevent external code from directly modifying an event's tags after creation or retrieval.
- Implements defensive copying in constructors and setter methods to prevent shared mutable state
- Exposes tags through an unmodifiable view to prevent external modification
- Updates test cases to work with the new immutable tag access pattern
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| GenericEvent.java | Adds defensive copying in constructor and setTags method, implements unmodifiable tag getter |
| ZapRequestEventValidateTest.java | Updates tests to create tag copies before modification since direct tag mutation is no longer possible |
| tag.setParent(this); | ||
| } | ||
| } | ||
|
|
||
| public List<BaseTag> getTags() { |
There was a problem hiding this comment.
Adding a new public getTags() method could be a breaking change if this method already exists in the class or its parent classes. Verify that this doesn't override an existing method with different behavior.
Suggested change
| public List<BaseTag> getTags() { | |
| public List<BaseTag> getBaseTags() { |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
GenericEventconstructors andsetTagsTesting
mvn -q verify(fails: Coverage checks have not been met for nostr-java-encryption)mvn -q -pl nostr-java-event -am testhttps://chatgpt.com/codex/tasks/task_b_6898e475555c833192749c48a74b0281