Add tests and adjust JaCoCo configuration #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds unit tests to the base and encryption modules while configuring JaCoCo code coverage to skip modules that don't have tests. The changes focus on improving test coverage for core functionality while pragmatically excluding modules from coverage analysis.
Key changes:
- Added comprehensive unit tests for encryption (MessageCipher04/44) and base module classes (Relay, Marker, Kind, Command, BaseKey)
- Updated POM files to skip JaCoCo coverage for modules without tests (id, examples, event, encryption, client, api)
- Expanded existing BaseKeyTest with additional method coverage
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| nostr-java-encryption/src/test/java/nostr/encryption/MessageCipherTest.java | New test file covering encryption/decryption for both MessageCipher04 and MessageCipher44 |
| nostr-java-base/src/test/java/nostr/base/*.java | New test files for Relay, Marker, Kind, and Command classes |
| nostr-java-base/src/test/java/nostr/base/BaseKeyTest.java | Enhanced existing tests with additional method coverage |
| */pom.xml | Added jacoco.skip=true property to exclude modules from coverage analysis |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
mvn -q verify(fails: Could not find a valid Docker environment, Testcontainers integration tests)https://chatgpt.com/codex/tasks/task_b_6896c4960e5c8331ba7cb5cd391eac29