Configure GitHub Packages deployment #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR configures GitHub Packages as an additional deployment target for Maven artifacts alongside the existing OSSRH deployment. The changes enable the project to publish releases to both Maven Central and GitHub Packages.
- Adds GitHub Packages repository configuration to Maven distributionManagement
- Updates the release workflow to authenticate with GitHub Packages using GITHUB_TOKEN
- Introduces a separate deployment step for GitHub Packages using altDeploymentRepository
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pom.xml | Adds GitHub Packages repository configuration to distributionManagement |
| .github/workflows/release.yml | Configures GitHub authentication and adds deployment step for GitHub Packages |
| @@ -18,6 +18,9 @@ jobs: | |||
| distribution: 'temurin' | |||
| java-version: '21' | |||
| cache: 'maven' | |||
| server-id: github | |||
| server-username: ${{ github.actor }} | |||
There was a problem hiding this comment.
[nitpick] The server-username should be configured as an environment variable (GITHUB_ACTOR) instead of using ${{ github.actor }} directly in the server configuration. This would be more consistent with the server-password configuration pattern.
Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
./mvnw -q verify(fails: java.net.SocketException: Network is unreachable)Network Access
repo.maven.apache.org– network is unreachablehttps://chatgpt.com/codex/tasks/task_b_6896c2a8ef908331a8f42dcaec869f57