feat: add retry to websocket client #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…pringWebSocketClient.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds retry functionality to the WebSocket client by integrating Spring Retry capabilities. The changes enable automatic retries for failed WebSocket send operations with configurable backoff strategies.
- Convert SpringWebSocketClient to a Spring component with retryable send methods
- Add Spring Retry configuration and dependencies
- Update existing code to accommodate the new constructor signature
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| SpringWebSocketClient.java | Convert to Spring component with @retryable annotations and dependency injection |
| RetryConfig.java | New configuration class to enable Spring Retry |
| SpringWebSocketClientTest.java | New test class to verify retry behavior with mock WebSocket client |
| pom.xml | Add Spring Retry and Spring Test dependencies |
| Multiple integration test files | Update constructor calls to accommodate new signature |
| WebSocketClientHandler.java | Update constructor calls for new SpringWebSocketClient signature |
| Documentation files | Document the new retry behavior |
Comments suppressed due to low confidence (1)
nostr-java-client/src/test/java/nostr/client/springwebsocket/SpringWebSocketClientTest.java:78
- The test method name 'recoverAfterMaxAttempts' is misleading. The test verifies that an exception is thrown after max attempts, not that recovery occurs. Consider renaming to 'throwsExceptionAfterMaxAttempts' or 'failsAfterMaxRetries'.
@Test
nostr-java-client/src/main/java/nostr/client/springwebsocket/SpringWebSocketClient.java
Outdated
Show resolved
Hide resolved
Comment on lines
+31
to
+39
| @Retryable(value = IOException.class, maxAttempts = 3, | ||
| backoff = @Backoff(delay = 500, multiplier = 2)) | ||
| @SneakyThrows | ||
| public List<String> send(@NonNull BaseMessage eventMessage) { | ||
| return webSocketClientIF.send(eventMessage.encode()); | ||
| } | ||
|
|
||
| @Retryable(value = IOException.class, maxAttempts = 3, | ||
| backoff = @Backoff(delay = 500, multiplier = 2)) |
There was a problem hiding this comment.
The retry configuration (maxAttempts = 3, delay = 500, multiplier = 2) is duplicated across both send methods. Consider extracting these values as constants or configurable properties to avoid duplication and improve maintainability.
Suggested change
| @Retryable(value = IOException.class, maxAttempts = 3, | |
| backoff = @Backoff(delay = 500, multiplier = 2)) | |
| @SneakyThrows | |
| public List<String> send(@NonNull BaseMessage eventMessage) { | |
| return webSocketClientIF.send(eventMessage.encode()); | |
| } | |
| @Retryable(value = IOException.class, maxAttempts = 3, | |
| backoff = @Backoff(delay = 500, multiplier = 2)) | |
| @NostrRetryable | |
| @SneakyThrows | |
| public List<String> send(@NonNull BaseMessage eventMessage) { | |
| return webSocketClientIF.send(eventMessage.encode()); | |
| } | |
| @NostrRetryable |
Copilot uses AI. Check for mistakes.
…pringWebSocketClient.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
mvn -q verify(fails: Could not find a valid Docker environment)Network Access
https://www.slf4j.org/codes.html#noProvidershttps://chatgpt.com/codex/tasks/task_b_688f585beab48331b2a0bf186f6ad4ad