Refactor integration tests client setup #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the integration test client setup by moving WebSocket client initialization from constructors to JUnit setup methods and removes an unused import.
- Converts WebSocket client initialization from constructor-based to
@BeforeEachsetup method pattern - Changes
springWebSocketClientfield fromfinalto mutable to support setup method initialization - Removes unused
GenericTagimport fromApiNIP99EventIT
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| nostr-java-api/src/test/java/nostr/api/integration/ApiNIP99EventIT.java | Refactors WebSocket client setup and removes unused import |
| nostr-java-api/src/test/java/nostr/api/integration/ApiNIP52EventIT.java | Refactors WebSocket client setup using BeforeEach pattern |
Comments suppressed due to low confidence (2)
nostr-java-api/src/test/java/nostr/api/integration/ApiNIP99EventIT.java:60
- [nitpick] The method name 'setup' is ambiguous and doesn't follow typical JUnit naming conventions. Consider renaming to 'setUp' or 'initializeWebSocketClient' for better clarity.
void setup() {
nostr-java-api/src/test/java/nostr/api/integration/ApiNIP52EventIT.java:32
- [nitpick] The method name 'setup' is ambiguous and doesn't follow typical JUnit naming conventions. Consider renaming to 'setUp' or 'initializeWebSocketClient' for better clarity.
void setup() {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SpringWebSocketClientin setup methodTesting
mvn -q verify(fails: Could not find a valid Docker environment)https://chatgpt.com/codex/tasks/task_b_688ac7315a188331a1d09de7db256b2e