Add generics to event factories #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds generic type support to the event factory classes to improve type safety when working with different tag types. The changes eliminate the need for unsafe type casting and provide better compile-time type checking.
- Makes
EventFactoryandGenericEventFactorygeneric with type parameters for event and tag types - Updates
NIP01class to use typedGenericEventFactoryinstances instead of unsafe casting - Adds unit tests to verify the new generic functionality works correctly
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
EventFactory.java |
Adds generic type parameters <E extends GenericEvent, T extends BaseTag> to the abstract base class |
GenericEventFactory.java |
Implements generic type parameter <T extends BaseTag> and updates constructor/method signatures |
NIP01.java |
Replaces unsafe type casting with properly typed GenericEventFactory instances |
NIP01Test.java |
Adds unit tests for the new generic methods with recipient lists and tag lists |
nostr-java-api/src/main/java/nostr/api/factory/impl/GenericEventFactory.java
Show resolved
Hide resolved
…ntFactory.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
EventFactoryandGenericEventFactorygenericGenericEventFactoryinNIP01mvn -q verifyTesting
mvn -q verifyhttps://chatgpt.com/codex/tasks/task_b_688a863639c48331803c6366cc2bd9d6