Enable relay-dependent integration tests #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enables relay-dependent integration tests to run conditionally based on relay availability. Previously, integration tests were statically disabled and required manual intervention to run.
- Replaces static
@Disabledannotations with dynamic relay availability checking - Introduces helper classes for checking relay connectivity before test execution
- Updates documentation to reflect automatic test skipping behavior
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
RelayAvailability.java |
New utility class to check if configured relays are reachable via socket connections |
BaseRelayIntegrationTest.java |
New base class that skips tests when relays are unavailable using JUnit assumptions |
Multiple *IT.java files |
Remove static @Disabled annotations and extend new base class for conditional execution |
README.md |
Documents automatic skipping of integration tests when relays are unreachable |
nostr-java-api/src/test/java/nostr/api/integration/RelayAvailability.java
Outdated
Show resolved
Hide resolved
nostr-java-api/src/test/java/nostr/api/integration/RelayAvailability.java
Outdated
Show resolved
Hide resolved
nostr-java-api/src/test/java/nostr/api/integration/RelayAvailability.java
Outdated
Show resolved
Hide resolved
…bility.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…bility.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…bility.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
RelayAvailabilityhelper andBaseRelayIntegrationTestbase class@Disabledannotations from integration testsTesting
mvn verifyhttps://chatgpt.com/codex/tasks/task_b_688a83c6ff908331ae096bb4ff153224