Improve TagDeserializer logic #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the TagDeserializer class to improve its maintainability by replacing a large switch statement with a map-based approach for tag deserialization. It also adds comprehensive test coverage for the tag deserialization functionality.
- Replaced switch statement with a static map of decoder functions for better maintainability
- Added dedicated test class with coverage for multiple tag types including AddressTag, EventTag, PriceTag, UrlTag, and GenericTag fallback
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| TagDeserializer.java | Refactored deserialization logic to use a map of decoder functions instead of switch statement |
| TagDeserializerTest.java | Added comprehensive test coverage for various tag types and generic fallback behavior |
nostr-java-event/src/main/java/nostr/event/json/deserializer/TagDeserializer.java
Show resolved
Hide resolved
…agDeserializer.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TagDeserializerto use a map of decoder functionsTagDeserializerTestcovering several tag typesTesting
mvn -q verifyhttps://chatgpt.com/codex/tasks/task_b_68890867bf448331950228605da8e756