Refactor TagSerializer to extend abstract base #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This refactoring simplifies the TagSerializer class by extending AbstractTagSerializer instead of directly extending StdSerializer, and moves GenericTag attribute handling logic to the applyCustomAttributes method.
- Simplified serialization logic by leveraging inheritance from an abstract base class
- Extracted GenericTag attribute handling to a focused override method
- Reduced code duplication and improved maintainability
| } catch (IOException e) { | ||
| throw new RuntimeException(e); | ||
| protected void applyCustomAttributes(ObjectNode node, BaseTag value) { | ||
| if (value instanceof GenericTag genericTag) { |
There was a problem hiding this comment.
The pattern matching instanceof with variable declaration requires Java 16+. Consider using traditional instanceof checking for better compatibility if the project targets older Java versions.
Suggested change
| if (value instanceof GenericTag genericTag) { | |
| if (value instanceof GenericTag) { | |
| GenericTag genericTag = (GenericTag) value; |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TagSerializerby extendingAbstractTagSerializerapplyCustomAttributesTesting
mvn -q verifyhttps://chatgpt.com/codex/tasks/task_b_6889084e88688331b29861ca86c185d7