Optimize BaseMessageDecoder parsing #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the BaseMessageDecoder class by eliminating redundant JSON parsing operations. The optimization caches the parsed JsonNode locally to avoid parsing the same JSON string multiple times within the validation method.
- Replaces double JSON parsing with single parse operation in
validateProperlyFormedJson - Adds null checks for JSON structure validation
- Includes test coverage for malformed JSON handling
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| BaseMessageDecoder.java | Optimizes JSON parsing by caching JsonNode and adds null validation for command/arg nodes |
| BaseMessageDecoderTest.java | Adds test case for malformed JSON structure validation |
nostr-java-event/src/main/java/nostr/event/json/codec/BaseMessageDecoder.java
Outdated
Show resolved
Hide resolved
…ageDecoder.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
BaseMessageDecoder.validateProperlyFormedJsonJsonNodelocally and reuse fieldsTesting
mvn -q verifyhttps://chatgpt.com/codex/tasks/task_b_6889086edd408331a62c294fa7a23485