Use HttpClient in Nip05Validator #220
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…tor.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Nip05Validator class to use the modern java.net.http.HttpClient API instead of the legacy HttpURLConnection for making HTTP requests. The change modernizes the HTTP client implementation while maintaining the same validation functionality.
- Replaced HttpURLConnection with HttpClient for HTTP requests
- Updated error handling to use HttpClient exceptions and proper thread interruption handling
- Simplified the HTTP response reading logic by using HttpResponse.BodyHandlers.ofString()
| StringBuilder content = new StringBuilder(response.body()); | ||
|
|
||
| // (2) | ||
| String pubKey = getPublicKey(content, localPart); |
There was a problem hiding this comment.
Creating a StringBuilder from response.body() is unnecessary since response.body() already returns a String. You can directly pass response.body() to getPublicKey() method.
Copilot uses AI. Check for mistakes.
| .replace("<domain>", domain) | ||
| .replace("<localPart>", localPart); | ||
|
|
||
| HttpClient client = HttpClient.newHttpClient(); |
There was a problem hiding this comment.
Creating a new HttpClient instance for each validation request is inefficient. Consider making HttpClient a static final field or instance field to reuse the same client across multiple validation calls.
Copilot uses AI. Check for mistakes.
Summary
java.net.http.HttpClientTesting
mvn -q verifyhttps://chatgpt.com/codex/tasks/task_b_688903761ec883318db857dc64aed1ef