Use shared SecureRandom #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
The PR improves NostrUtil by reusing a single SecureRandom instance instead of creating new instances for each random byte array generation, and adds comprehensive tests for the createRandomByteArray method.
- Replace per-call
SecureRandominstantiation with a shared static instance - Add unit tests to verify random byte array length and uniqueness properties
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| nostr-java-util/src/main/java/nostr/util/NostrUtil.java | Introduces shared SecureRandom instance to avoid repeated instantiation overhead |
| nostr-java-util/src/test/java/nostr/util/NostrUtilRandomTest.java | Adds new test class with coverage for createRandomByteArray functionality |
Comments suppressed due to low confidence (1)
nostr-java-util/src/test/java/nostr/util/NostrUtilRandomTest.java:23
- This test could theoretically fail due to the probabilistic nature of random generation. While extremely unlikely for 16-byte arrays, consider adding a retry mechanism or testing with smaller arrays multiple times to make the test more robust.
assertFalse(Arrays.equals(data1, data2), "Consecutive random arrays should differ");
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SecureRandominstance inNostrUtilcreateRandomByteArrayTesting
gradle clean test(fails: build halted mid-way)./mvnw -q test(fails: Network is unreachable)https://chatgpt.com/codex/tasks/task_b_6887ff2d10a08331823c4492511e8d81