Switch to slf4j logging #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR switches the logging framework from Java util logging to SLF4J by updating imports, annotations, and log statements across the codebase. It replaces Lombok's @Log annotation with @Slf4j and migrates Java util logging syntax to SLF4J's parameterized logging format for better performance and clarity.
- Replace Lombok
@Logwith@Slf4jannotations across all Java files - Convert Java util logging method calls to SLF4J syntax with parameterized messages
- Remove Java util logging imports and related configuration code
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| nostr-java-util/src/test/java/nostr/util/NostrUtilTest.java | Updates test class to use SLF4J logging |
| nostr-java-util/src/main/java/nostr/util/validator/Nip05Validator.java | Migrates validation logging to SLF4J with improved error handling |
| nostr-java-id/src/test/java/nostr/id/ZapReceiptEventTest.java | Updates test class logging annotation |
| nostr-java-id/src/test/java/nostr/id/EventTest.java | Updates test class logging annotation |
| nostr-java-id/src/test/java/nostr/id/EntityFactory.java | Updates factory class logging annotations |
| nostr-java-id/src/main/java/nostr/id/Identity.java | Updates identity class logging |
| nostr-java-examples/src/main/java/nostr/examples/NostrApiExamples.java | Migrates example application logging and removes util logging configuration |
| nostr-java-examples/src/main/java/nostr/examples/FilterRelays.java | Updates relay filtering logging |
| nostr-java-event/src/test/java/nostr/event/unit/*.java | Updates all event unit test classes to use SLF4J |
| nostr-java-event/src/main/java/nostr/event/message/EventMessage.java | Migrates event message logging |
| nostr-java-event/src/main/java/nostr/event/json/serializer/TagSerializer.java | Updates tag serialization logging |
| nostr-java-event/src/main/java/nostr/event/json/codec/GenericTagDecoder.java | Migrates tag decoder logging |
| nostr-java-event/src/main/java/nostr/event/impl/GenericEvent.java | Updates generic event logging |
| nostr-java-event/src/main/java/nostr/event/entities/UserProfile.java | Migrates user profile logging |
| nostr-java-crypto/src/main/java/nostr/crypto/nip44/EncryptedPayloads.java | Updates encryption logging |
| nostr-java-base/src/main/java/nostr/base/Relay.java | Adds new debug logging to relay creation |
| nostr-java-api/src/test/java/nostr/api/unit/*.java | Updates API unit test classes |
| nostr-java-api/src/test/java/nostr/api/integration/ApiEventIT.java | Updates integration test logging |
| nostr-java-api/src/main/java/nostr/api/NIP46.java | Migrates NIP46 logging |
| nostr-java-api/src/main/java/nostr/api/NIP44.java | Updates NIP44 logging |
| nostr-java-api/src/main/java/nostr/api/NIP04.java | Adds debug logging to NIP04 operations |
| @@ -42,14 +41,13 @@ | |||
| import java.util.concurrent.ExecutorService; | |||
| import java.util.concurrent.Executors; | |||
| import java.util.concurrent.TimeUnit; | |||
| import java.util.logging.Level; | |||
| import java.util.logging.LogManager; | |||
| import lombok.extern.slf4j.Slf4j; | |||
There was a problem hiding this comment.
Duplicate import: lombok.extern.slf4j.Slf4j is imported twice (lines 3 and 44). Remove the duplicate import on line 44.
Suggested change
| import lombok.extern.slf4j.Slf4j; |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@Logwith@Slf4jTesting
mvn -q verify(fails: EventTest.testNip05Validator)https://chatgpt.com/codex/tasks/task_b_68880d48f8e88331b343109b0ff06150