add kind 2022 for coinjoin #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tcheeric Can we have an ETA for this PR? |
|
Cc: @tcheeric |
|
Just seen this, will review. Thanks. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for a new Nostr event kind 2022 representing coinjoin pools. This addition enables the application to handle coinjoin-related events according to the Nostr protocol specification.
- Adds COINJOIN_POOL enum constant with kind number 2022
| @@ -17,6 +17,7 @@ public enum Kind { | |||
| SET_METADATA(0, "set_metadata"), | |||
| TEXT_NOTE(1, "text_note"), | |||
| RECOMMEND_SERVER(2, "recommend_server"), | |||
| COINJOIN_POOL(2022, "coinjoin_pool"), | |||
There was a problem hiding this comment.
The COINJOIN_POOL enum constant is inserted out of numerical order. Consider placing it after the existing entries to maintain ascending order by kind number, which would improve code readability and maintainability.
Suggested change
| COINJOIN_POOL(2022, "coinjoin_pool"), |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.