Skip to content

various minor updates & cleanup #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 41 commits into from
May 16, 2025
Merged

various minor updates & cleanup #206

merged 41 commits into from
May 16, 2025

Conversation

avlo
Copy link
Collaborator

@avlo avlo commented Apr 29, 2025

hi, eric. below PR consisting of minor changes/cleanup, with special note on first item:

  • GenericTag relocated from nostr.event.impl to nostr.event.tag

for any library users explicitly using GenericTag it is technically a breaking change although i suspect all/most users use concrete tag implementations (EventTag, PubKeyTag, etc) directly, which are all unchanged.

general:

  • AddressableTagFilter renamed to AddressTagFilter
  • TagSerializer split into BaseTagSerializer and GenericTagSerializer implementations
  • BaseTagSerializer and GenericTagSerializer extend newly introduced AbstractTagSerializer
  • BaseTagEncoder updated to use BaseTagSerializer
  • BaseTag.getFieldValue() potential null String result replaced with Optional
  • added VoteTag & VoteTagFilter
  • GenericMessage.decode() method updated to use Stream
  • BaseMessageDecoder cleaned up
  • added VoteTagFilter to FilterableProvider
  • cleaned up SignatureDeserializer
  • OkMessage.decode() cleaned up

tests:

  • refactored common/useful test patterns into CommonTestObjectsFactory class
  • new and updated tests added for all the above, all passing
  • various gradle build/config updates

all/any concerns, questions, additional considerations, etc, welcome as always

avlo added 30 commits March 21, 2025 02:54
@avlo
fixed old integrated tests for events containing generic tag and requ…
552df19 
…ests returning them
@avlo
BaseTagEncoder as record (removes need for lombok), TagSerializer ref…
a96b4a9 
…actor
@avlo
properly relocate GenericTag
166a2b9
@avlo
add tag serializer polymorphism
2929781
@avlo
cleanup
0405606
@avlo
cleanup
5505794
@avlo
basemessagedecor, eventmessage refactor
53877d8
@avlo
EventMessage refactor & cleanup
ace31b8
@avlo
BaseMessageDecoder and downstream Message classes cleaned up / refact…
85b8fcf 
…ored
@avlo
add spring boot junit retry
0a6a873
@avlo
add and set failsafe retry count to 1
6601bd0
@avlo
gradle test/check phase diff, pom reorg
2f68096
@avlo
add failed test assertion
351c9a4
@avlo
build.gradle & conventions minimizing
ea558cf
@avlo
gradle repo
bf2aa75
@avlo
determine use/need for GenericMessage
3780066
@avlo
renamed AddressableTagFilter to AddressTagFilter, added AddressTag tests
32bd20d
@avlo
renamed test to properly match class under test
1f5011c
@avlo
Merge branch 'generic_message_decoding' into develop
743e587
@avlo
BaseTag.getFieldValue() now returns Optional<String> instead of throw…
b22d217 
…ing exception

AbstractTagSerializer now uses above Optional in serialization stream

AbstractTagSerializer removed failableStream since no longer needed to handle above stream exceptions
test updates accordingly
@avlo
cleanup
eb38322
@avlo
resolve stash diffs
4110b77
@avlo
AddressTag variant, breaks TagDeserializer in superconductor
d8a3814
@avlo
add vote tag
9c5b8e6
@avlo
updated IT tests
ca379aa
@avlo
Merge branch 'develop_port_5555' into broken_address_tag_decoding
c757f2e
@avlo
addresstag updates
0115366
@avlo
addressTag filter updates
7cc9f34
@avlo
remove stream from serializer
9539ff3
@avlo
explicit identifiertag serializer
896367a
@avlo avlo requested a review from tcheeric April 29, 2025 04:13
@avlo avlo added the awaiting review PR awaiting review label Apr 29, 2025
@tcheeric
Copy link
Owner

Thanks nick. I also have some changes in the pipeline. I'll work on it this weekend or earlier.

@avlo
Copy link
Collaborator Author

avlo commented Apr 30, 2025 •
edited
Loading

yw, sounds good & thx you as well. btw, if easier/convenient for you, we can hold off on this PR until your changes are merged into develop branch, after which i'll update this PR with those changes and then merge this PR into develop branch.

@tcheeric tcheeric closed this May 4, 2025
@tcheeric tcheeric reopened this May 4, 2025
@tcheeric tcheeric added review:approved PR review approved and removed awaiting review PR awaiting review labels May 16, 2025
@avlo avlo merged commit be56d10 into tcheeric:develop May 16, 2025
@avlo
Copy link
Collaborator Author

avlo commented May 16, 2025 •
edited
Loading

excellent, thx eric- btw, minor supplemental update was just pushed into develop branch as well.

@avlo avlo deleted the upstream-develop-snapshot branch May 16, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcheeric tcheeric tcheeric approved these changes

Assignees
No one assigned
Labels
review:approved PR review approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avlo @tcheeric