-
Notifications
You must be signed in to change notification settings - Fork 24
Filters, FiltersEncoder, FiltersDecoder re-implemenation #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion' into filters_refactor
…Client removed nostr-java-controller, unused NostrSpringWebSocketClient updates Filters updates APINIP09EventTest use updated Filters mechanism FailableStream introduced for easier exception handling in streams removed deprecated/unused methods from NIP01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi, eric. below PR comprised of (predominantly)
Filters, FiltersEncoder, FiltersDecoder
re-implemenation for flexible use byReqMessage
and other nostr-java Filter clients as well as superconductor (which extensively leverages updated flexibility to properly handle requests, NIP-09/deletions and other filtering considerations).you'll notice git showing (below) 95 files changed, however, the vast majority of those were deletions of unused/vestigial classes. general overview of all changes/updates as follows:
updated:
new:
tests:
poms/packages/dependecies:
all below unused, removed- superseded by NostrSpringWebSocketClient
with all unit and integrations tests passing as expected (testing against SC develop branch). i'll additionally cancel my other outstanding PR as this one contains all its changes and more.
if any questions/concerns/omissions/etc pls advise