BaseMessageEncoder & BaseMessageDecoder refactor #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BaseMessageDecoder is now a delegate, with its previous explicit decision-tree logic refactored per message type, moved directly into one of the following classes:
CanonicalAuthenticationMessage
RelayAuthenticationMessage
CloseMessage
EoseMessage
EventMessage
NoticeMessage
OkMessage
ReqMessage
GenericMessage
BaseMessageEncoder no longer necessary since each message class directly now knows how to encode itself.
in other words, each class above now implements its own encode() and decode() methods, enabling polymorphic encoder/decoder behavior across all BaseMessage types.
thanks @tcheeric for repo push permission. @guilhermegps /others welcome to comment/suggest/deliberate etc on this PR otherwise will merge in ~48hours (Tuesday, June 4, 2024 05:00 PM UTC.)