NIP57 unit tests proper relay URI format #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These changes fixed the test failures for me. |
tcheeric
reviewed
May 27, 2024
| @@ -280,7 +280,7 @@ void testNIP57CreateZapRequestEvent() throws NostrException { | |||
| final String ZAP_REQUEST_CONTENT = "zap request content"; | |||
| final Long AMOUNT = 1232456L; | |||
| final String LNURL = "lnUrl"; | |||
| final String RELAYS_TAG = "relaystag"; | |||
| final String RELAYS_TAG = "ws://localhost:5555"; | |||
There was a problem hiding this comment.
Does this assume that a local relay must run on port 5555 for the unit test to work?
cc: @avlo , @kuiperanon
There was a problem hiding this comment.
no- it's exclusively/simply a test of:
- proper ZapRequestEvent object creation (via api.NIP57<>.createZapRequestEvent())
- it's requisite fields populated, and
- field values validated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.