Skip to content

Replace deepEqual with compareArray #3475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2022
Merged

Replace deepEqual with compareArray #3475

merged 1 commit into from
Apr 19, 2022

Conversation

ptomato
Copy link
Contributor

@ptomato ptomato commented Apr 11, 2022

Here is one place where compareArray is better fit for purpose, because we
are comparing an array.

@ptomato
Replace deepEqual with compareArray
4c55ff1 
Here is one place where compareArray is better fit for purpose, because we
are comparing an array.
@ptomato ptomato mentioned this pull request Apr 11, 2022
Open
@rwaldron rwaldron merged commit b68c751 into tc39:main Apr 19, 2022
@ptomato ptomato deleted the replace-deepequal branch April 19, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwaldron rwaldron rwaldron approved these changes

@ljharb ljharb ljharb approved these changes

@Ms2ger Ms2ger Ms2ger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ptomato @rwaldron @ljharb @Ms2ger