Split 'use' overloads into multiple methods #103
Conversation
|
A preview of this PR can be found at https://tc39.es/proposal-explicit-resource-management/pr/103. |
README.md
Outdated
| @@ -860,11 +873,84 @@ class PluginHost { | |||
| } | |||
|
|
|||
| [Symbol.dispose]() { | |||
| this.#socket = undefined; | |||
There was a problem hiding this comment.
Do these assignments do anything necessary for disposal, or are they just stylistic to keep something (what?) from referring to the private fields after Symbol.dispose is run?
There was a problem hiding this comment.
It's not necessary for the Disposable protocol, but good housekeeping in general. Any resources held by #socket would be freed when #disposables is disposed. Removing the reference to #socket would allow the object in #socket to be GC'd (since it's no longer usable).
In addition, a disposable object should try to ensure that any access is consistent with its "disposed" state, and clearing #socket (and #channel) might be one way to ensure that any attempt to use PluginHost after it has been disposed will fail due to a ReferenceError being thrown from any attempt to use the undefined #socket.
|
Unless there is any additional feedback, I'm hoping to merge this later today. |
Per the September 2022 plenary, the overloaded
usemethod should be split into multiple, distinct methods. These methods are as follows:use(value)- Adds a disposable resource to the stack.nullorundefined, it is returned as-is.[Symbol.dispose]()method, an error is thrown.adopt(value, onDispose)- Adds a non-disposable resource to the stack with a dispose callback.onDisposeis not callable, an error is thrown.valuecan be any value, includingnullorundefined. It will always be tracked.onDisposecallback will be invoked withvalueas its argument (i.e.,onDispose(value)).defer(onDispose)- Adds a callback to the stack.onDisposeis not callable, an error is thrown.onDisposecallback will be invoked with no argument (i.e.,onDispose()).Fixes #102