-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Editorial: "an Array", not "an Array object" [etc] #2489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love "Date object" to "Date", but it's fine.
spec.html
Outdated
@@ -11945,7 +11945,7 @@ <h1>Objectives</h1> | |||
|
|||
<p>This specification does not make any guarantees that any object will be garbage collected. Objects which are not live may be released after long periods of time, or never at all. For this reason, this specification uses the term "may" when describing behaviour triggered by garbage collection.</p> | |||
|
|||
<p>The semantics of WeakRef and FinalizationRegistry objects is based on two operations which happen at particular points in time:</p> | |||
<p>The semantics of WeakRefs and FinalizationRegistrys is based on two operations which happen at particular points in time:</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oof, FinalizationRegistrys
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ehhh I will just fix that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol that's also awkward if FInalizationRegistry is a dfn tho - making this "FinalizationRegistry objects" to avoid this problem was an explicit editorial review item for the weakref proposal :-p
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neither FinalizationRegistrys
nor FinalizationRegistries
will auto-link currently, so we might as well go with the better one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<p>The semantics of WeakRefs and FinalizationRegistrys is based on two operations which happen at particular points in time:</p> | |
<p>The semantics of a WeakRef and a FinalizationRegistry are based on two operations which happen at particular points in time:</p> |
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm concerned about both automatic linking and also natural pluralization; i suppose if ecmarkup could detect y → ies
then it's not a big deal, but it makes it awkward to speak about out loud.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i suppose if ecmarkup could detect
y → ies
then it's not a big deal
I was thinking I'd just allow dfn
to specify pluralizations explicitly.
it makes it awkward to speak about out
Sorry, what becomes awkward?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ys
obviously, when spoken aloud, nobody will come up with the spelling; the ies
one just seems weird to me even though also obviously, the pluralization of registry
is registries
, it's weird when it's a camelcased thing.
not a strong opinion, it's just weird :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think FinalizationRegistrys is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased on #2492, so now the plural FinalizationRegistrys
should link.
Ugh, hold off merging for a sec, I just noticed a typo edit: ok fixed |
#2483 proposes to change a few occurrences of "TypedArray object" to "TypedArray". (There were some usages of the latter form already.) That seems better, so we might as well do that everywhere it makes sense to do so.
I've changed most uses of "an X object" to be "an X", with the following exceptions: