Skip to content

(ignore) Normative: Add private methods and getter/setters. #1667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2021
Merged

(ignore) Normative: Add private methods and getter/setters. #1667

merged 1 commit into from
May 12, 2021

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Aug 14, 2019

This includes changes from https://tc39.es/proposal-private-methods/.

@Ms2ger
Copy link
Contributor Author

Ms2ger commented Aug 14, 2019

This is on top of #1655; see Ms2ger/ecma262@class-fields...private-methods for just these changes.

@Ms2ger Ms2ger mentioned this pull request Aug 14, 2019
Merged
@ljharb
Copy link
Member

ljharb commented Aug 14, 2019

Can you change the base branch of this PR to the one it's on top of? That way the diff will be readable.

@ljharb ljharb added needs test262 tests The proposal should specify how to test an implementation. Ideally via github.com/tc39/test262 normative change Affects behavior required to correctly evaluate some ECMAScript source text pending stage 4 This proposal has not yet achieved stage 4, but may otherwise be ready to merge. proposal This is related to a specific proposal, and will be closed/merged when the proposal reaches stage 4. labels Aug 14, 2019
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Aug 15, 2019

I don't think so; that branch is in my own repo, not this one.

@littledan littledan added has test262 tests and removed needs test262 tests The proposal should specify how to test an implementation. Ideally via github.com/tc39/test262 labels Sep 2, 2019
@ljharb ljharb changed the title Normative: Add private methods and getter/setters. (ignore) Normative: Add private methods and getter/setters. Sep 2, 2019
@ljharb
Copy link
Member

ljharb commented Sep 2, 2019

Deferring to #1668; I’ll keep this one up to date.

@ljharb ljharb self-assigned this Sep 2, 2019
@ljharb ljharb mentioned this pull request Jan 7, 2020
Closed
@ljharb ljharb mentioned this pull request Jan 22, 2020
Closed
@ljharb ljharb marked this pull request as draft July 15, 2020 21:57
@Ms2ger @ryzokuken
@caiolima @jmdyck @bakkot @ljharb
Normative: Add public and private class fields, static class features…
56b5e8b 
…, private methods & getters/setters

This includes changes from https://tc39.es/proposal-class-fields/.
This includes changes from https://tc39.es/proposal-private-methods/.
This includes changes from https://tc39.es/proposal-static-class-features/.

Co-authored-by: Ms2ger <Ms2ger@gmail.com>
Co-authored-by: Ujjwal Sharma <ryzokuken@igalia.com>
Co-authored-by: Caio Lima <ticaiolima@gmail.com>
Co-authored-by: Michael Dyck <jmdyck@ibiblio.org>
Co-authored-by: Kevin Gibbons <bakkot@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
@ljharb ljharb force-pushed the private-methods branch from 9889a39 to 56b5e8b Compare May 12, 2021 21:39
@ljharb ljharb merged commit 56b5e8b into tc39:master May 12, 2021
@annevk annevk mentioned this pull request Apr 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ljharb ljharb

Labels
has test262 tests normative change Affects behavior required to correctly evaluate some ECMAScript source text pending stage 4 This proposal has not yet achieved stage 4, but may otherwise be ready to merge. proposal This is related to a specific proposal, and will be closed/merged when the proposal reaches stage 4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ms2ger @ljharb @littledan