Skip to content

Improve path handling and skip not existing folders #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 28, 2020
Merged

Improve path handling and skip not existing folders #17

merged 3 commits into from
Feb 28, 2020

Conversation

gzsombor
Copy link
Contributor

No description provided.

@tbillington
Copy link
Owner

Hi @gzsombor thank you for your contribution!

Canonicalize does make the path a bit weird on windows, eg \\?\C:\Users\Trent\code\kondo\test_dir\node_project but it's apparently legit (https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file?redirectedfrom=MSDN#maxpath) so I'll allow it. If users down the line have issues with it we can work out a solution then.

@tbillington tbillington merged commit 298abae into tbillington:master Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gzsombor @tbillington