-
Notifications
You must be signed in to change notification settings - Fork 51
Move endpoint to client and expose it #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
What do you think about doing a soft migration? Once the new version is fully released, we can remove the old logic. |
I’m open to it. My initial approach was to expose the endpoint from Before committing to a soft migration, I’d be interested to know if anyone relies on What do you think? |
I can’t say for sure whether anyone is using I’d recommend taking a soft upgrade path—this way, we avoid introducing breaking changes and give users a chance to adapt, ideally with clear upgrade instructions. UPDATE: If you think it will be difficult to support, let's update CHANGELOG.md to note that this includes breaking changes in HTTP. |
No I don't think it's too difficult 😊 I thought about it and now the endpoint is stored in both classes for the time being! That's okay with you? |
daccb69
to
ade9b83
Compare
Ping @miry, can't click re-review for some reason |
@treagod Can you add your changes to CHANGELOG? |
This PR moves region and endpoint resolution logic from
Awscr::S3::Http
intoAwscr::S3::Client
. The HTTP layer now receives a fully resolved URI from the client.This makes it easier to:
The Http class is now purely transport-focused, with no knowledge of regions or endpoint logic.