Skip to content

Fixed an overflow when files were listed that are above 2G #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2024
Merged

Fixed an overflow when files were listed that are above 2G #116

merged 1 commit into from
Jul 7, 2024

Conversation

philipp-classen
Copy link
Contributor

File sizes can exceed the range of Int32, resulting in errors like that:

Unhandled exception: Invalid Int32: "2305083320" (ArgumentError)
  from /usr/lib/crystal/string.cr:438:83 in 'to_i32'
  from /usr/lib/crystal/string.cr:349:5 in '__crystal_main'
  from /usr/lib/crystal/crystal/main.cr:129:5 in 'main'
  from /usr/lib/libc.so.6 in '??'
  from /usr/lib/libc.so.6 in '__libc_start_main'

@taylorfinnell taylorfinnell merged commit 39f4310 into taylorfinnell:master Jul 7, 2024
@philipp-classen philipp-classen deleted the support_filesizes_above_2g branch July 7, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philipp-classen @taylorfinnell