Skip to content

Fix Awscr::S3::Response::HeadObjectOutput.meta method #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix Awscr::S3::Response::HeadObjectOutput.meta method #111

wants to merge 1 commit into from

Conversation

compumike
Copy link
Contributor

Bug fix for:

In lib/awscr-s3/src/awscr-s3/responses/head_object_output.cr:43:7                                                                  
                                                                                                                                   
 43 | response.headers.each do |k, v|                                                                                              
      ^-------                                                                                                                     
Error: undefined local variable or method 'response' for Awscr::S3::Response::HeadObjectOutput

Thanks! ❤️

@miry
Copy link
Collaborator

miry commented Mar 4, 2025

@compumike Could you add tests to cover the problematic response to ensure it's properly handled?

@miry miry mentioned this pull request Mar 16, 2025
Merged
@miry
Copy link
Collaborator

miry commented Mar 16, 2025

Merged your changes and added the integration tests for head_object method in #128

@miry miry closed this Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@compumike @miry